-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESROGUE-684 - Frame.getNumpy now allows user defined data type #1027
Open
bengineerd
wants to merge
18
commits into
pre-release
Choose a base branch
from
get-numpy
base: pre-release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to
Frame.getNumpy()
The
Frame.getNumpy()
method now takes an additionaldtype
argument, which allows a numpy type to be specified for the returned array.Additionally, the
getNumpy()
method now has default arguments for all parametersAllowing for calls such as
The
count
argument defaults to 0, which functionally will return the entire array starting atoffset
.The
offset
andcount
parameters are still specified in bytes, not in the dtype size.Other changes
The
offset
argument ofFrame.readPy()
andFrame.writePy()
has also been given a default of 0 when called from python.A new
Frame.getBa()
method has been added that will allocate the bytearray internally and return it. This makes things a bit more concise in python when reading from a Frame.The
getBa()
method takes anoffset
andcount
which function the same as ingetNumpy()
with the same defaults.Also, a new
Frame.getMemoryview()
method has been added that allocates a bytearray but returns it as amemoryview
. This allows for efficient slicing of the frame data without any copying. In most cases where copyless slicing is needed, agetNumpy()
would be preferred, butgetMemoryview()
is useful for efficiently parsing complex header structures.