-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: secure tokens #276
Merged
Merged
chore: secure tokens #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR title failed to match (chore|style|test|feat|fix|docs): .+
…for windows image
calebtonn
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the
secureliCI.yml
workflow into a "Build & Test" workflow that runs on every push to any branch other thanmain
and a "Publish" workflow that only runs on push tomain
. The Publish workflow will fall use the Build & Test workflow, so those jobs will run prior to releasing/publishing changes.The primary focus of this is to stop using an org secret to house the GH App private key, so it is only accessible by workflows that use the
publish
environment, which is where the new environment secret exists that houses the private key. This keeps contributors from being able to modify a workflow to allow it to run code that will expose the contents of a secret. Now, any workflow attempting to use the Actions Helper GH App token must use thepublish
environment, which is only available from themain
branch.Resolves #275