Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run BATS test in pipeline #403

Merged
merged 5 commits into from
Jan 25, 2024

Conversation

tdurk93
Copy link
Contributor

@tdurk93 tdurk93 commented Jan 25, 2024

secureli-128

Running BATS to validate e2e tests on every PR push. They seem to run pretty quickly so it shouldn't add much latency to the pipeline.

Changes

  • BATS tests now run in the pipeline and print out verbose results (This work was done by @joe-stafford )
  • Enabling ci: as a valid PR prefix, as it's supported by conventional commits.

Testing

  • Fixed existing BATS tests & enabled them in the pipeline

Clean Code Checklist

  • Meets acceptance criteria for issue
  • New logic is covered with automated tests
  • Appropriate exception handling added
  • Thoughtful logging included
  • Documentation is updated
  • Follow-up work is documented in TODOs
  • TODOs have a ticket associated with them
  • No commented-out code included

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title failed to match (chore|style|test|feat|fix|docs|ci): .+

@tdurk93 tdurk93 changed the title CI: Run BATS test in pipeline CI: Run BATS test in pipeline Jan 25, 2024
@tdurk93 tdurk93 changed the title CI: Run BATS test in pipeline ci: Run BATS test in pipeline Jan 25, 2024
@github-actions github-actions bot dismissed their stale review January 25, 2024 23:22

All good!

@tdurk93 tdurk93 marked this pull request as ready for review January 25, 2024 23:23
Copy link
Contributor

@joe-stafford joe-stafford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@joe-stafford joe-stafford merged commit 05deb62 into main Jan 25, 2024
9 of 10 checks passed
@joe-stafford joe-stafford deleted the feat/secureli-128-run-bats-test-in-pipeline branch January 25, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants