Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bugfix for error on init of C# repos #513

Merged
merged 5 commits into from
Apr 18, 2024
Merged

feat: bugfix for error on init of C# repos #513

merged 5 commits into from
Apr 18, 2024

Conversation

isaac-heist-slalom
Copy link
Contributor

secureli-512

Secureli init failed/errors out on initialization of repo with C# language. This PR resolves that issue.

Changes

  • Made 'rev' property on pre-commit repo setting optional.

Testing

  • All existing unit tests passing

Clean Code Checklist

  • Meets acceptance criteria for issue
  • New logic is covered with automated tests
  • Appropriate exception handling added
  • Thoughtful logging included
  • Documentation is updated
  • Follow-up work is documented in TODOs
  • TODOs have a ticket associated with them
  • No commented-out code included

@isaac-heist-slalom isaac-heist-slalom linked an issue Apr 11, 2024 that may be closed by this pull request
Secureli init fails/errors out on initialization of repo with C# language #512
Closed
ambhrin-slalom
ambhrin-slalom approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@ambhrin-slalom ambhrin-slalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manually validated and it worked as expected

@isaac-heist-slalom isaac-heist-slalom merged commit 4a7efc2 into main Apr 18, 2024
5 checks passed
@isaac-heist-slalom isaac-heist-slalom deleted the bugfix/secureli-512-secureli-init-fails-on-first-pass-multiple-languages branch April 18, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaKeishaTurnerSlalom LaKeishaTurnerSlalom LaKeishaTurnerSlalom approved these changes

@ambhrin-slalom ambhrin-slalom ambhrin-slalom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Secureli init fails/errors out on initialization of repo with C# language
3 participants
@isaac-heist-slalom @ambhrin-slalom @LaKeishaTurnerSlalom