Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolves setting save failure on empty secureli.yaml #83

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

AldosAC
Copy link
Contributor

@AldosAC AldosAC commented Apr 27, 2023

#77 Bugfix for failing to write ignore rule to .secureli.yml when it does not exist yet

Note that this PR is for Github issue #77 and not Jira ticket STFT-077. Branch was named as such to pass branch validation until branch validation has been updated.

Adds conditional logic so that saving the settings file does not attempt to modify the echo property if there is no echo property.

@AldosAC AldosAC marked this pull request as ready for review April 27, 2023 17:28
@AldosAC AldosAC merged commit 6b80c20 into main Apr 27, 2023
@AldosAC AldosAC deleted the fix/stft-077-echo-error-on-ignore branch April 27, 2023 17:38
@gabenegron gabenegron added the bug Something isn't working label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants