Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

[qz-3635] Correct precedence when parsing join conditions #43

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

wemrysi
Copy link
Contributor

@wemrysi wemrysi commented Jan 31, 2018

Corrects the parsing of join conditions so that queries like

select * from a inner join b on a.id = b.id limit 10

parse correctly. Prior to this fix the limit would be considered part of the join condition and not the outer query.

@wemrysi wemrysi requested a review from cryogenian January 31, 2018 16:52
@garyb
Copy link
Member

garyb commented Feb 2, 2018

@wemrysi this looks good to me - I assume the change is to match the way it parses in Quasar?

@wemrysi
Copy link
Contributor Author

wemrysi commented Feb 2, 2018

@garyb Yeah, both were wrong and the Quasar parser was fixed in quasar-analytics/quasar#3452 so this is just applying the same fix here.

Copy link
Member

@garyb garyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@garyb garyb merged commit 2e2cd7a into slamdata:master Feb 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants