4.0

[slaughter550]

Resolves #4

[slaughter550]

@jackwh is there anything else you think should be added to V4?

[jackwh]

@slaughter550 Thanks for the update, and apologies for my slow response! Some suggestions below... First two would be great, second two are just nice-to-haves:

1. The current composer.json file locks the Intercom API version to a specific release ("intercom/intercom-php": "3.2.0"). It would be best to use semantic version ranges, so we can always benefit from any minor-version improvements as soon as they are released by Intercom. This issue prevented me from being able to use the delete user API calls added v3.2.0 of the API in June, until the dependency version was bumped in this library in September.

2. PhpStorm doesn't support autocomplete when using the Intercom facade, as shown in the screenshot below. I'm using Laravel IDE Helper to add PhpStorm autocomplete for everything else, and I know other package facades are able to support autocomplete too, but I'm not sure specifically how to add it. Might be as easy as a @mixin docblock tag? Or maybe more involved, I'm not sure...

3. Update the package requirements to support PHP 7.1+ only (required as per Intercom API v4 requirements), and therefore upgrade codebase to take advantage of 7.1 features and syntax.

4. Native support for queueing or retrying Intercom API requests would be useful. In my application, I'm recording user events in numerous places. If the Intercom API goes down (which seems to happen far more often than I'd like), the requests fail. To save littering my code with try catch statements, I ended up creating a wrapper for a Laravel queued job to make the API request, when it can be asynchronous. This way if the API goes down, it will automatically re-try later. Native support for this would be neat.

Hope that helps!

[jackwh]

@slaughter550 Sorry, wrote those comments before I'd checked what had changed on this PR!

Point 1 still applies (though against v4 instead of v3). Point 3 might need to be revised to PHP v7.1 instead of v7.0 which it is now, as Intercom API v4 only supports v7.1 and above.

[slaughter550]

@jackwh

1. Addressed
2. Can you tell me which package facades do it and I'll see if I can find what makes them tick?
3. Addressed.
4. I agree it fails very often. I will look into a config option for failures. Whether to queue or throw