Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version and copyright #7

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Update version and copyright #7

merged 3 commits into from
Jan 23, 2025

Conversation

typiconman
Copy link
Contributor

@yanone Please check if I did this correctly.

@yanone
Copy link
Contributor

yanone commented Jan 23, 2025

Sure, other than the openTypeOS2Selection missing from fontinfo.plist in this PR, it looks good.

Since it appears you have started generating binaries with gftools on your end, please continue to do so and add binaries to your repo, after removing the fonts folder from .gitignore. I was never a fan of the cloud build, because it breaks too often, as you've noticed yourself.

@typiconman typiconman merged commit 44d30b2 into main Jan 23, 2025
1 check failed
@typiconman typiconman deleted the fixo branch January 23, 2025 13:22
@typiconman
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@typiconman @yanone