Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first attempt at color inversion #60

Merged
merged 4 commits into from
Jan 11, 2020
Merged

first attempt at color inversion #60

merged 4 commits into from
Jan 11, 2020

Conversation

pgmmpk
Copy link
Collaborator

@pgmmpk pgmmpk commented Apr 18, 2019

added invertColor option to \cuKrukPara.

Idea is to allow this:

\cuKrukPara[invertColor]{ aaa \\ bbb}

@pgmmpk pgmmpk requested a review from typiconman April 18, 2019 23:59
@pgmmpk
Copy link
Collaborator Author

pgmmpk commented Apr 19, 2019

Addresses issue #55

@typiconman
Copy link
Contributor

Hmm. I get an error:
! Package xkeyval Error: no value specified for key `invertColor'.

Here's my M(n)WE:

\documentclass{article}
\usepackage{polyglossia}
\usepackage{fontspec}
\usepackage{churchslavonic}
\setdefaultlanguage{churchslavonic}
\newfontfamily\churchslavonicfont[Script=Cyrillic,Ligatures=TeX]{PonomarUnicode.otf}
\newfontfamily\musicFont[Scale=1.5]{MezenetsUnicode}
\let\cuKrukFont=\musicFont
\begin{document}
\cuKruk[invertColor]{𜽰𜼅}{Тво}
\end{document}

@pgmmpk
Copy link
Collaborator Author

pgmmpk commented Apr 19, 2019

Oops. this option exists only for \cuKrukPara, not (yet) for \cuKruk. Please try with \cuKrukPara - seem to work here

@typiconman
Copy link
Contributor

Still no luck. If I try to compile this code:

\documentclass{article}
\usepackage{polyglossia}
\usepackage{fontspec}
\usepackage{churchslavonic}
\setdefaultlanguage{churchslavonic}
\newfontfamily\churchslavonicfont[Script=Cyrillic,Ligatures=TeX]{PonomarUnicode.otf}
\newfontfamily\musicFont[Scale=1.5]{MezenetsUnicode}
\let\cuKrukFont=\musicFont

\begin{document}

\cuKrukPara[invertColor]{
𜽟 𜾆𜼱𜼇
\\
Хри-сто́съ
}

\end{document}

I get the message: ! Package xkeyval Error: no value specified for key `invertColor'..

If I specify a vaue for invertColor, as the message suggests (e.g., invertColor=1), I get a different error:
! Use of \cu@kinovar@color doesn't match its definition.

@pgmmpk
Copy link
Collaborator Author

pgmmpk commented Apr 20, 2019

I see many problems there. Will need some time to review.

@typiconman
Copy link
Contributor

Yes, now it works!

@pgmmpk pgmmpk merged commit 7df0d12 into master Jan 11, 2020
@pgmmpk pgmmpk deleted the invert-kruk-colors branch January 11, 2020 19:25
@typiconman typiconman restored the invert-kruk-colors branch January 13, 2020 08:33
@typiconman typiconman deleted the invert-kruk-colors branch January 13, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants