Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests, Docker integration tests, additional serialization coverage, and proc_macro support for reply port type args #39

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

slawlor
Copy link
Owner

@slawlor slawlor commented Jan 30, 2023

This PR adds a few things

  1. Some initial docker-based, networked e2e integration tests to simulate a real cluster
  2. More unit tests on port handling + serialization/deserialization of ractor_cluster messages
  3. Missing serialization support for more basic types (char and bool) along with vectors of all supported types (numerics, String, char, bool, etc)
  4. Fix in proc macro to return all of the generics on an RpcReplyPort when possible. This allows for complex nested types to the port to be reply types.

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 87.98% // Head: 71.46% // Decreases project coverage by -16.53% ⚠️

Coverage data is based on head (478c1ec) compared to base (3031d3d).
Patch coverage: 90.03% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #39       +/-   ##
===========================================
- Coverage   87.98%   71.46%   -16.53%     
===========================================
  Files          27       40       +13     
  Lines        3586     5729     +2143     
===========================================
+ Hits         3155     4094      +939     
- Misses        431     1635     +1204     
Impacted Files Coverage Δ
ractor/src/port/mod.rs 95.45% <0.00%> (-4.55%) ⬇️
ractor_cluster/src/net/listener.rs 0.00% <ø> (ø)
ractor_cluster/src/net/session.rs 0.00% <0.00%> (ø)
ractor_cluster/src/node/client.rs 0.00% <0.00%> (ø)
ractor_cluster/src/node/mod.rs 3.89% <0.00%> (ø)
ractor_cluster/src/node/node_session/mod.rs 13.29% <0.00%> (ø)
ractor_cluster/src/remote_actor/mod.rs 0.00% <0.00%> (ø)
ractor_cluster_derive/src/lib.rs 96.93% <87.50%> (ø)
ractor_cluster/src/node/node_session/tests.rs 90.17% <90.17%> (ø)
ractor_cluster/src/node/auth.rs 92.89% <98.60%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@slawlor slawlor force-pushed the integration_tests branch 3 times, most recently from d6016e7 to 97d1f49 Compare January 31, 2023 02:31
@slawlor slawlor mentioned this pull request Jan 31, 2023
13 tasks
@slawlor slawlor force-pushed the integration_tests branch 2 times, most recently from 0cac831 to 13d6e48 Compare January 31, 2023 14:57
Docker based integration tests for networked calls (eventually) using the containers as mock hosts.

Additionally adds some missing predefined serialization implementations for `Vec<T>` concrete types and `char`
@slawlor slawlor marked this pull request as ready for review January 31, 2023 16:47
@slawlor slawlor merged commit 8ff6dfc into main Jan 31, 2023
@slawlor slawlor deleted the integration_tests branch January 31, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant