Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD: Display gp floating clinics (gp-f) #341

Merged
merged 10 commits into from
Mar 30, 2023
Merged

ADD: Display gp floating clinics (gp-f) #341

merged 10 commits into from
Mar 30, 2023

Conversation

bananica
Copy link
Collaborator

PixelSnap 2023-03-28 at 19 52 59
PixelSnap 2023-03-28 at 19 53 17

@bananica bananica requested review from stefanb and jalezi March 28, 2023 18:08
stefanb
stefanb reviewed Mar 28, 2023
View reviewed changes
src/locales/it.json Outdated Show resolved Hide resolved
stefanb
stefanb reviewed Mar 28, 2023
View reviewed changes
src/locales/sl.json Outdated Show resolved Hide resolved
@jalezi
Copy link
Collaborator

jalezi commented Mar 28, 2023

On mobile looks ok - iPhone SE2. 😀

"dostopnost" has overflow

image

stefanb
stefanb reviewed Mar 28, 2023
View reviewed changes
src/locales/en.json Outdated Show resolved Hide resolved
@stefanb
Copy link
Member

stefanb commented Mar 29, 2023 •
edited
Loading

Non critical: Feedback form has visible field "obseg zaposlitve":
image
(gray background on the screenshot because of mouse hover)

stefanb
stefanb reviewed Mar 29, 2023
View reviewed changes
src/locales/it.json Outdated Show resolved Hide resolved
jalezi
jalezi reviewed Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@jalezi jalezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried with #008cd0? It is the icon's fill color.

@stefanb
Copy link
Member

stefanb commented Mar 29, 2023

Have you tried with #008cd0? It is the icon's fill color.

Indeed, that one looks even better.
image
I didn't see it because it was not present in CSS, but set directly in SVG

@stefanb @jalezi
Adjusted mediumBlue to the same blue as in SVG file
cee53b8 
Co-Authored-By: Jaka Daneu <44704999+jalezi@users.noreply.github.com>
jalezi
jalezi approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@jalezi jalezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stefanb @bananica
Re-sort doctors if needed
7a53aff 
Co-Authored-By: bananica <bane@bananica.com>
@stefanb stefanb merged commit 1729d28 into master Mar 30, 2023
@stefanb stefanb deleted the gp-f branch March 30, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalezi jalezi jalezi approved these changes

@stefanb stefanb stefanb approved these changes

Assignees
No one assigned
Labels
deploy-preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bananica @jalezi @stefanb