Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ⬆️ all deps, but eslint-plugin-react & react-leaflet #468

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

jalezi
Copy link
Collaborator

@jalezi jalezi commented Mar 6, 2024

We can not upgrade 2 deps:

  • eslint-plugin-react,
  • react-leaflet

As for react-leaflet, there is a workaround, I am pretty sure that eslint-plugin-react can not be upgraded. Most likely more and more dependencies will break the app.

Since create-react-app is not maintained anymore (last update was 2 years ago), the React team recommends using production-grade React frameworks like NextJS, Remix, Gatsby, or Expo for native apps. While frameworks are the preferred choice, the React team also recommends using Vite or Parcel for custom-build processes.

I guess the easiest solution is to use Vite but I have never done it nor used it. Using a production-grade framework needs a major rewrite.

Here is an article on how to migrate to Vite.

@jalezi jalezi requested a review from stefanb March 6, 2024 05:56
@jalezi
Copy link
Collaborator Author

jalezi commented Mar 6, 2024

@stefanb on creating PR the playwright test failed. After adding a deploy-preview label` I re-run and it worked.

#471 playwright job succeed on first try without 🏷️
https://github.com/sledilnik/zdravniki/actions/runs/8168384693/job/22330362751?pr=471

@stefanb stefanb merged commit d792b95 into master Mar 6, 2024
6 checks passed
@stefanb stefanb deleted the feat/upgrade-deps branch March 6, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants