Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change *.zh.yml for Chinese translation to be displayed correctly #491

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

limimiking
Copy link

The file names of *.zh.yml is inconsistent with the key "zh-CN" in the files.
If zh is chosen for APP_LOCALE in env file, the contents will not be displayed correctly.
So I change the zh-CN to zh in *.zh.yml, then the contents are displayed normally.

Before correction:
Screenshot 2024-07-23 at 10 29 14

After correction:
Screenshot 2024-07-23 at 16 47 26

@gnepud
Copy link
Member

gnepud commented Jul 23, 2024

Hi @limimiking

I knew the file names of .zh.yml is inconsistent with the key "zh-CN" in the files.
However, I cannot merge your pull request because Crowdin uses "zh-CN" in this files "
.zh.yml". If we change "zh-CN" to "zh," I won't be able to sync these Chinese translation files.
Therefore, you can use "zh-CN" in the environment to resolve this issue.

RAILS_LOCALE=zh-CN
APP_LOCALE=zh-CN
MOMENT_LOCALE=zh-cn
SUMMERNOTE_LOCALE=zh-CN
ANGULAR_LOCALE=zh-cn
FULLCALENDAR_LOCALE=zh-cn
INTL_LOCALE=zh-Hans-CN

Thanks

@limimiking
Copy link
Author

Thanks for this information. I think you should change the prompt in setup.sh or add some instructions in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants