Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XRegExp.escape with hyphen/comma/hash returns regex incompatible with ES6 flag u #323

Closed
slevithan opened this issue Feb 16, 2021 · 1 comment
Closed

XRegExp.escape with hyphen/comma/hash returns regex incompatible with ES6 flag u #323

slevithan opened this issue Feb 16, 2021 · 1 comment
Labels
bug

Comments

@slevithan
Copy link
Owner

slevithan commented Feb 16, 2021 •
edited
Loading

ES6 flag u disallows \-, so we need an alternative way to escape hyphens.

This is similar to #197, which fixed this for whitespace.

Edit: Same problem for escaped , and #.
@slevithan slevithan added the bug label Feb 16, 2021
@slevithan
Copy link
Owner Author

Last diff fixed in 93f3001.

slevithan added a commit that referenced this issue Feb 16, 2021
@slevithan
XRegExp.escape: Escape # and , in way that works with ES6 flag u (#323)
c34a926
@slevithan slevithan changed the title XRegExp.escape with hyphen returns regex incompatible with ES6 flag u XRegExp.escape with hyphen/comma/hash returns regex incompatible with ES6 flag u Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slevithan