-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to @babel/runtime-corejs3 #280
Upgrade to @babel/runtime-corejs3 #280
Conversation
@josephfrazier, do you know why the failure? Feel free to go ahead and land build or other improvements, and/or publish new tags/releases, without review. |
Hmm, not sure. Here's the error, for reference:
I'll see if I can figure it out.
Thanks! I'll have to remember the entire release process, but I think we have it written down in an issue/PR somewhere. |
Though, it looks like I don't have permission to publish on NPM, so I'll still have to ask you to do that, unless you want to add me as an owner. |
Here’s the list of steps: #205 (comment). I’ve also just added you as an Thanks for all your help with this! |
Will the new version 4.2.x be published on npmjs.com? |
@josephfrazier & @slevithan , |
Thanks @slevithan, I'm going to start preparing a new minor release (v4.3.0) following the steps you linked. For reference, here are the changes that will be included (Unicode 12.1.0 and If all goes well, I'll probably publish to NPM sometime this week. |
Changes include: * Upgrading from Unicode 11.0.0 to Unicode 12.1.0: slevithan#278 * Upgrading from `@babel/runtime-corejs2` to `@babel/runtime-corejs3`: slevithan#280 To generate this commit, I followed the steps at slevithan#205 (comment) See more context at slevithan#280 (comment)
If I could advise something: include typescript definitions. |
Hey @tdjastrzebski, I'm happy to include typescript definitions in a future release, but I don't have enough TS experience to add them myself. Do you know anyone who can help out? |
@josephfrazier: @Bartvds, @jfahrenkrug or @sigo may be able to help. |
@tdjastrzebski I'd be happy to help with including the TS defs in the package. Maybe open a new ticket for it? |
@jfahrenkrug see #284 |
Changes include: * Upgrading from Unicode 11.0.0 to Unicode 12.1.0: #278 * Upgrading from `@babel/runtime-corejs2` to `@babel/runtime-corejs3`: #280 To generate this commit, I followed the steps at #205 (comment) See more context at #280 (comment)
Just published v4.3.0: https://www.npmjs.com/package/xregexp/v/4.3.0
I'll try to take a look at the PRs for this and see if we can get TS defs into the next release, thanks! |
Fixes #279