PropertyTypeHintSniff: Fixed false positive

slevomat · Feb 1, 2020 · c8f2e2b · c8f2e2b
1 parent 16f856e
commit c8f2e2b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/SlevomatCodingStandard/Sniffs/TypeHints/PropertyTypeHintSniff.php b/SlevomatCodingStandard/Sniffs/TypeHints/PropertyTypeHintSniff.php
@@ -170,10 +170,16 @@ private function checkTypeHint(
 					continue;
 				}
 
+				$isTraversable = TypeHintHelper::isTraversableType(TypeHintHelper::getFullyQualifiedTypeHint($phpcsFile, $propertyPointer, $typeHint), $this->getTraversableTypeHints());
+
+				if (!$isTraversable && count($traversableTypeHints) > 0) {
+					return;
+				}
+
 				if (
 					!$innerTypeNode instanceof ArrayTypeNode
 					&& !$innerTypeNode instanceof ArrayShapeNode
-					&& TypeHintHelper::isTraversableType(TypeHintHelper::getFullyQualifiedTypeHint($phpcsFile, $propertyPointer, $typeHint), $this->getTraversableTypeHints())
+					&& $isTraversable
 				) {
 					$traversableTypeHints[] = $typeHint;
 				}

diff --git a/tests/Sniffs/TypeHints/data/propertyTypeHintEnabledNativeNoErrors.php b/tests/Sniffs/TypeHints/data/propertyTypeHintEnabledNativeNoErrors.php
@@ -121,4 +121,9 @@ class Whatever
 	/** @var mixed[]|array|Traversable */
 	public $moreTraverasableTypes;
 
+	/**
+	 * @var mixed[]|array|SomethingThatLooksAsArray
+	 */
+	public $moreDifferentTypes;
+
 }