Cover short ternaries in UselessTernaryOperatorSniff #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewilkybarkid
changed the title
Contributor
Author
|
AppVeyor failure is unrelated. |
Contributor
|
Can you provide some real-world use case for this? I'd be really interested in seeing one. |
Contributor
Author
|
Heh, so would I! Just spotted it when adding a (rather unrealistic) test case so our CS (https://github.com/libero/php-coding-standard/pull/50/files#diff-abd230f3b7a1a6e0e56045b82f054108R9). Reasonably quick and should be harmless to add though. |
Contributor
|
@thewilkybarkid Please squash commits to one commit and name it in the same way as commits in master.Thank you. |
thewilkybarkid
force-pushed
the
useless-short-ternary
branch
from
e6d77a3 to
6b0c352
Compare
Contributor
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather an edge case!