Pronterface compatibility broken because presets are saved without extension in slic3r.ini

[xoan]

Version

current master

Operating system

Arch Linux 4.9.16-1-lts x86_64
Xfce 4.12

Behavior

The way the default presets are saved now in slic3r.ini breaks the compatibility with the Slic3r integration in Pronterface:

• https://github.com/kliment/Printrun/blob/master/printrun/pronterface.py#L2171

Because Pronterface expects the preset name contains the full file name including .ini.

Probably it is an issue to be solved in Pronterface, right?

[alranel]

Oh, I didn't know that. I thought it only used the public CLI commands. I think it's easy enough to modify Pronterface to append .ini if it's not there...

[lordofhyphens]

@kliment FYI...

[alranel]

I fixed this in kliment/Printrun#817
I could merge it into the Printrun repository myself, but I can't test it at the moment. @xoan, if you run Pronterface from git would you have a chance to test my change?

[xoan]

Sorry, it doesn't work (despite the syntax error in the if sentence with no colon at the end :P). It still updates slic3r.ini with full preset filename, including extension.

To solve this issue, it probaly involves some more changes in load_slic3r_configs and read_slic3r_config.

I can take a look into it this night. Let me try.

[xoan]

OK, I just made a PR (kliment/Printrun#818) with changes that take into account the Slic3r version from slic3r.ini.

It is tested in GNU/Linux, with both 1.2.9 and 1.3.0-dev Slic3r version.

[alranel]

Thank you for contributing that @xoan. I merged the PR in Printrun :)

[xoan]

Nice :)

[ntoff]

This seems to break integration with the Prusa edition of slic3r (1.35.5), with slic3r integration enabled, it appends .ini to the file, leading to being unable to locate the profile.

Cannot find specified configuration file (C:\Users\redacted\AppData\Roaming\Slic3r\print\default.ini.ini).

[bubnikv]

There is a similar issue posted on the Prusa3D fork: prusa3d/PrusaSlicer#367

…

On Sun, Jul 9, 2017 at 10:39 AM, ntoff ***@***.***> wrote: This seems to break integration with the Prusa edition of slic3r (1.35.5), with slic3r integration enabled, it appends .ini to the file, leading to being unable to locate the profile. Cannot find specified configuration file (C:\Users\redacted\AppData\ Roaming\Slic3r\print\default.ini.ini). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3813 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFj5IxPtoRQiDxroAnSxb_4LBz5qEkpUks5sMJHAgaJpZM4Mqgz5> .

[xoan]

It should be solved by patching Prusa edition of Slic3r to follow the current Slic3r behavior.

[ntoff]

or more easily, I just added a check to pronterface to not add .ini to the profile if it detects the prusa edition of slic3r