Required onError parameter in graphql ValidationContext #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the [recent release](https://github.com/graphql/graphql-js/releases/tag/v15.0.0) of graphql-js plugin there has been a breaking change in `ValidationContext` class which now requires a fourth "onError" parameter in its constructor. See: https://github.com/graphql/graphql-js/pull/2130/files Right now, if the client sends a query without a required parameter, the graphql server throws an error which is incorrectly handled in the `graphql-query-complexity` plugin so it throws a new error: ``` TypeError: this._onError is not a function at ValidationContext.reportError (.../node_modules/graphql/validation/ValidationContext.js:46:10) at .../node_modules/graphql-query-complexity/dist/QueryComplexity.js:121:49 at Array.reduce (<anonymous>) at QueryComplexity.nodeComplexity (.../node_modules/graphql-query-complexity/dist/QueryComplexity.js:85:62) at QueryComplexity.onOperationDefinitionEnter (.../node_modules/graphql-query-complexity/dist/QueryComplexity.js:56:41) at Object.enter (.../node_modules/graphql/utilities/TypeInfo.js:370:25) at Object.visit (.../node_modules/graphql/language/visitor.js:243:26) at getComplexity (.../node_modules/graphql-query-complexity/dist/QueryComplexity.js:24:15) ``` To fix this, we can add an empty error handler (this plugin only calculates complexity, not handling invalid GQL queries so an empty function should be fine)
Closed
|
Thanks for the PR! I just merged #30 which also contains this fix among others and adds support for GraphQL v15. |
|
Thanks @ivome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the recent release of graphql-js plugin there has been a breaking change in
ValidationContextclass which now requires a fourth "onError" parameter in its constructor.See: https://github.com/graphql/graphql-js/pull/2130/files
Right now, if the client sends a query without a required parameter, the graphql server throws an error which is incorrectly handled in the
graphql-query-complexityplugin so it throws a new error:To fix this, we can add an empty error handler (this plugin only calculates complexity, not handling invalid GQL queries so an empty function should be fine)