Include meta fields (__typename, __type, __schema) against total field complexity [2] #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sequel for #90 covered with test
original PR is been inactive for half a year, I decided to open a new one
Original description:
What
Update
QueryComplexity.ts
to count meta fields against total complexity. The current implementation only considers fields included in the schema, which omits:__typename
,__type
and__schema
.Why
Denial of service attacks are possible by creating many aliases of meta fields:
edit:
simple 300kb with 35k
__typename
fields query is able to load server for almost half-a-minute. It can be used for DoS attacks.Considerations
If counting each field as
1
cost, common introspection queries will have a cost around180
. Consumers of the library may need to increase the maximum.edit: Probably, to keep compatibility, we can make some optional parameter to include these fields in total complexity, but I think it's unnecessary