fix(a11y): add missing alternative texts #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- provide `alt` attributes for `<image>` elements. Use`alt=""` for decorative images - add `HiddenText` component for icon button usage. The component uses the WindiCSS class `src-only` to correctly hide elements visually but read texts out for screen readers closes slidevjs#1142
antfu
reviewed
Oct 7, 2023
| @@ -157,6 +158,7 @@ watchEffect(() => { | |||
| </div> | |||
| </Transition> | |||
| <button v-if="value" class="fixed text-2xl top-4 right-4 slidev-icon-btn text-gray-400" @click="close"> | |||
| <HiddenText text="Close" /> | |||
There was a problem hiding this comment.
I wonder if in this case, would a title to the button would be more straightforward?
There was a problem hiding this comment.
I think the title attribute isn't the best way to make things more accessible (even if at the first look, I thought the same). See for example: https://www.a11yproject.com/posts/title-attributes/#:~:text=Short%20answer%3A%20Don't%20use,and%20possibly%20not%20even%20used.
It could be tackled with aria attributes as well, but there are also some older screenreaders and browser caught IE 😃 having problems with hidden elements.
The CSS trick is a pretty old but effective one which should work for almost every device and browser.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
altattributes for<image>elements. Usealt=""for decorative imagesHiddenTextcomponent for icon button usage. The component uses the WindiCSS classsrc-onlyto correctly hide elements visually but read texts out for screen readerscloses #1142