fix: optimize deps errors in global installation mode #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
KermanX
changed the title
KermanX
commented
Apr 30, 2024
antfu
reviewed
Apr 30, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1409, fix #1440, fix #1479, fix #1538, fix #1385.
Updated CI to upload built packed packages as artifacts, because I can't pack them on my machine, and this can save GitHub's money. And YARN is removed from CI because of some installation problem. As a vue-based project, I think only a very small percent of users will use yarn.
This is still a workaround. I tried for days to make Vite resolve properly when there are both alias and optimizeDeps, but failed, and I can't make a minimal reproduction of what's happening in Slidev's global mode for opening an issue in Vite.