Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add more community addons #1895

Merged
merged 6 commits into from
Dec 13, 2024
Merged

docs: add more community addons #1895

merged 6 commits into from
Dec 13, 2024

Conversation

tonai
Copy link
Contributor

@tonai tonai commented Oct 9, 2024

No description provided.

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 0dbc405
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/674a74c0e4ffe70008f16cc5
😎 Deploy Preview https://deploy-preview-1895--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Oct 9, 2024

Open in Stackblitz

@slidev/client

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/client@1895

create-slidev

npm i https://pkg.pr.new/slidevjs/slidev/create-slidev@1895

create-slidev-theme

npm i https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@1895

@slidev/parser

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/parser@1895

@slidev/cli

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/cli@1895

@slidev/types

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/types@1895

commit: 0dbc405

@carlobellettini
Copy link

repo links are missing the s of slidev 6 out 7 times

for example

repo: 'https://github.com/Smile-SA/lidev-component-spotlight',

must be

repo: 'https://github.com/Smile-SA/slidev-component-spotlight',

repo: 'https://github.com/Smile-SA/slidev-addon-sync',
},
{
id: 'slidev-component-pager',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to have a components category then? What do you think @KermanX?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding some tags/keywords to each addon? For example, Component/Intergration/Tool

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to add some context, the first add-ons I created were named slidev-component-* because I was working on them before we released the add-on feature in Slidev (released with v0.32 on May 20th).
The name "addon" was not official at that time, so I chose "component" and was too lazy to change the name later.
But yes, it can still be interesting to have tags 👍

@KermanX
Copy link
Member

KermanX commented Nov 30, 2024

@tonai, I've just added some tags to the addons. However, I'm unsure about the accuracy of these tags. Could you please review them? 😊

By the way, I noticed that some of the addons are asking users to create a global-top.vue, for example, https://github.com/Smile-SA/slidev-component-scroll#usage. It seems that now Slidev also loads global-top.vue from the addons' roots. And in some cases slide-top.vue appears to be more suitable than global-top.vue.

@KermanX KermanX changed the title doc: add addons docs: add addons Nov 30, 2024
@tonai
Copy link
Contributor Author

tonai commented Dec 4, 2024

@KermanX Sorry for the delay.
The tags look fine.
And thanks for the hint I will check that.

@KermanX KermanX changed the title docs: add addons docs: add more community addons Dec 13, 2024
@KermanX KermanX merged commit 1b5b369 into main Dec 13, 2024
20 checks passed
@KermanX KermanX deleted the tonai-addons branch December 13, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants