Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: allow to remove shortcuts #1922

Merged
merged 2 commits into from
Nov 30, 2024
Merged

fix!: allow to remove shortcuts #1922

merged 2 commits into from
Nov 30, 2024

Conversation

twitwi
Copy link
Contributor

@twitwi twitwi commented Oct 30, 2024

defineShortcutsSetup are supposed to receive the set of shortcuts and return the new set of shortcuts (based on the received one, possibly removing some). So we have a chain of setups.

The current code does a union of setups, merging all results, breaking the previous semantics (which is more useful and which is reflected by the documentation).

This patch brings back the new behavior, using the new, clean setup syntax.

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for slidev failed.

Name Link
🔨 Latest commit 2ac9edc
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/674a7aa2e5479600081bc0b7

Copy link

pkg-pr-new bot commented Oct 30, 2024

Open in Stackblitz

@slidev/client

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/client@1922

create-slidev-theme

npm i https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@1922

create-slidev

npm i https://pkg.pr.new/slidevjs/slidev/create-slidev@1922

@slidev/parser

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/parser@1922

@slidev/cli

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/cli@1922

@slidev/types

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/types@1922

commit: 2ac9edc

@KermanX KermanX removed the before v1 label Nov 18, 2024
@KermanX KermanX changed the title Fix: cannot remove shortcuts (merge setups instead of chain setups) fix!: allow to remove shortcuts Nov 29, 2024
@antfu antfu merged commit a47b8bc into main Nov 30, 2024
16 of 20 checks passed
@antfu antfu deleted the fix/shortcuts-not-removable branch November 30, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants