Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide sync controls in SPA mode #1989

Closed
wants to merge 1 commit into from

Conversation

KermanX
Copy link
Member

@KermanX KermanX commented Dec 27, 2024

As title.

Also, is it possible to simplify the sync controls UI?

btw, I am confused about the new screen mirroring feature - Why does the presenter want to see his own tab/screen?

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 3e428ef
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/676e49b60a013b0008e08ca4
😎 Deploy Preview https://deploy-preview-1989--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Dec 27, 2024

Open in Stackblitz

@slidev/client

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/client@1989

create-slidev

npm i https://pkg.pr.new/slidevjs/slidev/create-slidev@1989

@slidev/parser

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/parser@1989

create-slidev-theme

npm i https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@1989

@slidev/cli

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/cli@1989

@slidev/types

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/types@1989

commit: 3e428ef

@antfu
Copy link
Member

antfu commented Dec 27, 2024

SPA syncing would also work in the same browser via Boardcast API, is in some cases it would still be useful. Maybe we could have an option to disable it, or smartly detect how many tab instances are created.

Screen mirroring feature is for presentation on a same laptop with two monitor.

@KermanX KermanX closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants