feat: move built emoji-mart package to root
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this git repository consists of [yarn workspaces](https://yarnpkg.com/features/workspaces), which enable to define mono repo packages within one repository, but we want to use only one package `emoji-mart`. `slido-frontend` does not use yarn2 yet, so the workspace can't be specified see yarnpkg/yarn#1570 (comment). As we are of the full control of this forked repository, the fastest and easiest is to change the folder structure to consist only of this package 🎉. I was also considering this 3rd party subfolder generation https://github.com/EqualMa/gitpkg, but decided not to depend on potentially security risk of 3rd party provider. The dist related properties were adjusted in the root package.json from emoji-mart package, as this root package is used as a reference when usign this dependency.
andrejkaPry
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this git repository consists of yarn workspaces, which enable to define mono repo packages within one repository, but we want to use only one package
emoji-mart.slido-frontenddoes not use yarn2 yet, so the workspace can't be specified see yarnpkg/yarn#1570 (comment).As we are of the full control of this forked repository, the fastest and easiest is to change the folder structure to consist only of this package 🎉.
I was also considering this 3rd party subfolder generation https://github.com/EqualMa/gitpkg, but decided not to depend on potentially security risk of 3rd party provider.
The dist related properties were adjusted in the root package.json from emoji-mart package, as this root package is used as a reference when usign this dependency.