Remove whitespace when linebreaking quoted attributes. Closes #685 #729
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjford
force-pushed
the
fix_linebreak_whitespace
branch
from
6609bf6 to
f623d5d
Compare
|
The space is intentional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still may be missing a very good reason that this space exists, but there's been no mention of one on the issue (#685), and removing it doesn't seem to break anything, so I figured I'd throw in a PR.
I also updated the readme to reflect that as a consequence of this change, if you really do want a space at the linebreak, it needs to be explicitly included (fixed a typo too).