Remove over-eager ftplugin indent settings #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not really appropriate for filetype plugins to set indent-related options. In this case, the appropriate options (autoindent, expandtab, and sw=2) are already being set in indent/slim.vim. smartindent is meant for C-like languages where the normal C indentation doesn't work. There's no reason to use it here (autoindent is what you want, but that's already set in indent/slim.vim). There's no reason to set all of tabstop, softtabstop, and shiftwidth; and when using smarttab, only shiftwidth is required. However, smarttab is a global option with no buffer-local value, so setting it (even with setlocal) changes the option for all buffers. Thus it should be left up to the user.
|
I also removed the same settings from ftdetect/slim.vim, as again, they are already being set in indent/slim.vim, and an ftdetect file should not change settings. |
This is the standard way to set the filetype, and allows syntax.vim to set the correct syntax highlighting automatically.
stonean
pushed a commit
that referenced
this pull request
Aug 11, 2013
Remove over-eager ftplugin indent settings
|
Thank you for the contributions! |
|
Awesome, thanks for the speedy merge! |
|
Same issue here. File detection is broke. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not really appropriate for filetype plugins to set indent-related options.
In this case, the appropriate options (autoindent, expandtab, and sw=2) are already being set in indent/slim.vim.
smartindent is meant for C-like languages where the normal C indentation doesn't work. There's no reason to use it here (autoindent is what you want, but that's already set in indent/slim.vim).
There's no reason to set all of tabstop, softtabstop, and shiftwidth; and when using smarttab, only shiftwidth is required.
However, smarttab is a global option with no buffer-local value, so setting it (even with setlocal) changes the option for all buffers. Thus it should be left up to the user.
Thus I propose just removing this file completely.