Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate slime: move modules to staging dir #152

Merged
merged 1 commit into from
May 30, 2022

Conversation

cywang1905
Copy link
Contributor

@cywang1905 cywang1905 commented May 27, 2022

To aggregate Slime project, move all slime modules to slime main project. The specific path is staging/src/slime.io/slime/modules.

The main changes are as below:

  1. copy each module to slime under staging/src/slime.io/slime/modules
  2. modify go.mod slime.io/slime/framework => ... /... /... /... /... /... /framework
  3. modify publish.sh ... /... /... /... /... /... /bin/publish.sh "$@"
  4. modify slime/modules/bundle_example/go.mod
  5. modify slime-boot's publish.sh path
  6. change the hyperlink address of each readme

We can develop all modules in single project to keep version consistency, ameanwhile they do not bother others in the future.

@cywang1905 cywang1905 marked this pull request as draft May 27, 2022 09:53
@@ -3,7 +3,7 @@
MODS=${MODS:-"lazyload limiter plugin"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can traverse these modules through the file directory so that we don't have to list them explicitly. But this can be done later

@cywang1905 cywang1905 marked this pull request as ready for review May 30, 2022 02:06
@@ -0,0 +1,27 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove ths .gitignore file of modules

WORKDIR /
COPY manager.exe ./manager

ENTRYPOINT ["/manager"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no newline at the end of file

message DomainAlias {
string pattern = 1;
repeated string templates = 2;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline


option go_package = "slime.io/slime/modules/lazyload/api/v1alpha1";

// ServiceFence是在社区Sidecar资源之上的一层封装,其主要作用与Sidecar资源相同,可以隔绝服务
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> en

map<string, Destinations> domains = 1;
map<string, string> metricStatus = 3;
map<string, bool> visitor = 2;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline


COPY manager.exe ./proxy-app

ENTRYPOINT ["/proxy-app"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

#!/usr/bin/env bash

export MOD=global-sidecar
../../../slime/bin/publish.sh "$@"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

image:
pullPolicy: Always
repository: docker.io/slimeio/slime-plugin
tag: v0.2.0_linux_amd64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

"slime.io/slime/modules/plugin/api/v1alpha1"
)

type NeteaseType interface {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename it?

memory: 800Mi
image:
repository: docker.io/slimeio/pilot
tag: {{globalSidecarPilotTag}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

volumes:
- name: tmp
emptyDir: {}
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

memory: 400Mi
image:
repository: docker.io/slimeio/slime-global-sidecar
tag: v0.2.0-1b93bf7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use find . -type f -print0 | xargs -0 -L1 bash -c 'test "$(tail -c 1 "$0")" && echo "No new line at end of $0"' or pcregrep -LMr '\n\Z' . to find all files with no newline at the end

@YonkaFang YonkaFang merged commit c0ff7eb into slime-io:master May 30, 2022
@believening
Copy link
Contributor

@cywang1905
Copy link
Contributor Author

This directory is the staging area for packages that have been split to their own repository. The content here will be periodically published to respective top-level k8s.io repositories.

Will we periodically published to respective top-level slim.io repositories? Just like k8s

Existing module repos should be retained, but not updated for now. It may be better to publish to respective repos regularly until slime community reaches a higher level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants