Fix invalid vs panic and lazyload supports old istio version #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YonkaFang
reviewed
Jun 21, 2022
| @@ -266,9 +277,15 @@ spec: | |||
| name: 0.0.0.0_{{ . }} | |||
| filterChain: | |||
| filter: | |||
| {{- if $gs.oldVersion }} | |||
There was a problem hiding this comment.
change to legacyFilterName
YonkaFang
reviewed
Jun 21, 2022
| @@ -290,11 +313,7 @@ spec: | |||
| typed_per_filter_config: | |||
| envoy.filters.http.lua: | |||
| "@type": type.googleapis.com/envoy.extensions.filters.http.lua.v3.LuaPerRoute | |||
| source_code: | |||
There was a problem hiding this comment.
why we move the add-source-ns-header lua code from per-route filter config to filter config?
There was a problem hiding this comment.
compatiable with istio 1.7, cause istio 1.7 related envoy does support source_code param
YonkaFang
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.some invalid vs can cause vs controller panic, fix this problem
2.global-sidecar runs in privileged mode
3.global-sidecar supoorts istio version 1.7+ plugin name
4.lua plugin usage changed,due to compatibale with istio 1.7
5.global-sidecar supports customize pod annotations