Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add selfResourceRev to specified rev in servicefence #208

Merged
merged 1 commit into from
Nov 4, 2022
Merged

add selfResourceRev to specified rev in servicefence #208

merged 1 commit into from
Nov 4, 2022

Conversation

MouceL
Copy link
Contributor

@MouceL MouceL commented Nov 3, 2022

In some scenarios, it is necessary to add istio.io/rev to resources which is generated by slime itself

NOTE:

Resources related to the slime module.

  • Resources generated by slime itself: servicefence

  • Resources handled by slime: smarlimiter/envoyplugin/pluginmanager/rvs/envoyfilter

So, we add selfResourceRev in global config, when this parameter is set, the resources created by slime itself will add the labels istio.io/rev: {{ .selfResourceRev }}

message Global {
  // ignore ...

  // if SelfResourceRev is specified, the value of SelfResourceRev will be patched to resources which generated by slime itself, just like serviceFence
  // smartlimiter/envoyplugin/pluginmanager is excluded because these envoyfilter are generated by users or higher-level services
  // envoyfilter/sidecar is excluded because these resources generated base on their owner resources
  string selfResourceRev = 13;
}

usage: slimeboot =>

global:
  selfResourceRev: rev-12

@MouceL MouceL requested a review from YonkaFang November 3, 2022 06:35
@MouceL MouceL changed the title add slimeRev to specified rev in servicefence add selfResourceRev to specified rev in servicefence Nov 3, 2022
@YonkaFang YonkaFang merged commit 5dde505 into slime-io:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants