Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use istioRev to manage cr's reconcile instead of istioRev and configRev #213

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Conversation

MouceL
Copy link
Contributor

@MouceL MouceL commented Nov 7, 2022

  1. istioRev: determines the scope of management

usage

If a is set, then whatever b is

if istioRev is empty, then whatever strictRev is true or false, slime will manage the all cr

global:
  istioRev: ""

if strictRev is true, slime will only manage the cr with labels istio.io/rev: istio-17 or istio.io/rev: istio-112

global:
  istioRev: istio-17,istio-112
  strictRev: true

if strictRev is false, slime will manage the cr with label istio.io/rev: istio-17 or istio.io/rev: istio-112 or cr without rev label

global:
  istioRev: istio-17,istio-112
  strictRev: false

if strictRev is false and istioRev is empty, slime will manage the all cr

global:
  strictRev: false
  1. slime will retrive config via configRev instead of istioRev+configRev

@MouceL MouceL marked this pull request as draft November 7, 2022 13:04
@MouceL MouceL changed the title use isitoRev to manage cr reconcile instead of istioRev and configRev use istioRev to manage cr's reconcile instead of istioRev and configRev Nov 8, 2022
@MouceL MouceL marked this pull request as ready for review November 8, 2022 03:34
@MouceL MouceL marked this pull request as draft November 8, 2022 03:50
@MouceL MouceL marked this pull request as ready for review November 8, 2022 07:05
@YonkaFang YonkaFang merged commit 3688091 into slime-io:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants