Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nacos source support fetching instances from all namespaces #293

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

believening
Copy link
Contributor

Before we fetch the nacos service only in a specific namespace/group, which can be set in this way:

NacosSource:
  Namespace: public
  Group: DEFAULT_GROUP

Now we support fetching the nacos service in all group in all namespaces, which can be set in this way:

NacosSource:
  AllNamespaces: true

When "AllNamespaces" is enabled, we merge instances with the same service name from different namespaces and groups into a single ServiceEntry.

We use the API /nacos/v1/ns/catalog/services for fetching all services in all groups in a specific namespace. This api, which we found in the nacos 1.4.x console, is not documented in the nacos openAPI documentation, so we cannot guarantee that this feature is compatible with the latest version of nacos in the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants