change global-sidecar and global-sidecar-pilot template file #91
Conversation
doc/en/slime-boot.md
Outdated
| slimeNamespace: slime #customize the slime deployed namespace filled in sidecar, same with spec.namespace | ||
| istioNamespace: istio-operator #customize the istio deployed namespace filled in sidecar, same with spec.istioNamespace | ||
| slimeNamespace: slime #customize the slime deployed namespace filled in sidecar, same with spec.namespace | ||
| istioNamespace: istio #customize the istio deployed namespace filled in sidecar, same with spec.istioNamespace |
There was a problem hiding this comment.
here is an example to show how to customize the namespace deployed istio component, use istio instead of istio-system
| @@ -36,6 +36,9 @@ spec: | |||
| limits: | |||
| cpu: 200m | |||
| memory: 200Mi | |||
| image: | |||
| repository: istio/proxyv2 | |||
| tag: 1.7.0 | |||
There was a problem hiding this comment.
Later we may need to declare the dependent versions of global sidecar and pilot somewhere, and then we can refer to them in the test code instead of hardcode
There was a problem hiding this comment.
also " repository: docker.io/slimeio/slime-lazyload
tag: v0.2.2" why we use a fixed version lazyload for test?
There was a problem hiding this comment.
Hardcode is really a problem. v0.2.2 is needed to change to the newest image tag
doc/zh/slime-boot.md
Outdated
| @@ -129,7 +129,7 @@ metadata: | |||
| namespace: slime | |||
| spec: | |||
| namespace: slime #自定义slime部署的namespace，和config.global.slimeNamespace一致 | |||
| istioNamespace: istio-operator #自定义istio部署的namespace，和config.global.istioNamespace一致 | |||
| istioNamespace: istio #自定义istio部署的namespace，和config.global.istioNamespace一致 | |||
There was a problem hiding this comment.
here is an example to show how to customize the namespace deployed istio component, use istio instead of istio-system
cywang1905
force-pushed
the
master
branch
2 times, most recently
from
179dc34
to
1c0576b
Compare
No description provided.