Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit-config: only run shellcheck on the final thing #220

Merged
merged 1 commit into from
Jul 22, 2023
Merged

pre-commit-config: only run shellcheck on the final thing #220

merged 1 commit into from
Jul 22, 2023

Conversation

Artoria2e5
Copy link
Contributor

Doing so actually gives stronger detection of problems. Fix #219.

@Artoria2e5
pre-commit-config: only run shellcheck on the final thing
c822a86 
Doing so actually gives stronger detection of problems. Fix slimm609#219.
@slimm609
Copy link
Owner

jobs are failing

@Artoria2e5
Copy link
Contributor Author

Yes, that's to be expected because there's a bug in NX code.

@slimm609 slimm609 merged commit 7694735 into slimm609:main Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimm609 slimm609 slimm609 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shellcheck hook does not detect #212 problem
2 participants
@Artoria2e5 @slimm609