Merge branch 'bugfix/uri-ToString-method'

Closes #52
slimphp · Sep 8, 2018 · 5924b12 · 5924b12
2 parents 5139884 + 1589b3b
commit 5924b12
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 4 deletions.
diff --git a/composer.json b/composer.json
@@ -46,5 +46,13 @@
     "psr-4": {
       "Slim\\Tests\\Http\\": "tests/"
     }
+  },
+  "scripts": {
+      "test": [
+          "@phpunit",
+          "@phpcs"
+      ],
+      "phpunit": "php vendor/bin/phpunit",
+      "phpcs": "php vendor/bin/phpcs"
   }
 }
diff --git a/src/Uri.php b/src/Uri.php
@@ -768,8 +768,8 @@ public function __toString()
 
         $path = '/' . ltrim($path, '/');
 
-        return ($scheme ? $scheme . ':' : '')
-            . ($authority ? '//' . $authority : '')
+        return ($scheme !== '' ? $scheme . ':' : '')
+            . ($authority !== '' ? '//' . $authority : '')
             . $path
             . ($query !== '' ? '?' . $query : '')
             . ($fragment !== '' ? '#' . $fragment : '');
@@ -789,7 +789,7 @@ public function getBaseUrl()
         $scheme = $this->getScheme();
         $authority = $this->getAuthority();
 
-        return ($scheme ? $scheme . ':' : '')
-            . ($authority ? '//' . $authority : '');
+        return ($scheme !== '' ? $scheme . ':' : '')
+            . ($authority !== '' ? '//' . $authority : '');
     }
 }
diff --git a/tests/UriTest.php b/tests/UriTest.php
@@ -597,4 +597,16 @@ public function testRequestURICanContainParams()
         );
         $this->assertEquals('abc=123', $uri->getQuery());
     }
+
+    public function testUriDistinguishZeroFromEmptyString()
+    {
+        $expected = 'https://0:0@0:1/0?0#0';
+        $this->assertSame($expected, (string) Uri::createFromString($expected));
+    }
+
+    public function testGetBaseUrlDistinguishZeroFromEmptyString()
+    {
+        $expected = 'https://0:0@0:1/0?0#0';
+        $this->assertSame('https://0:0@0:1', (string) Uri::createFromString($expected)->getBaseUrl());
+    }
 }