Correct ServerRequest::getParam method PHPDoc #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PHPDoc type of ServerRequest class getParam method's $default argument is changed from "string" to "mixed", as dependent on request parameter its default value can be expected to have another type(e.g. boolean). And if there is a PHPStan or other analyser running in project an error is reported on cases, where $default argument type is not string. So as there is no obstacle for doing this change, it is correct to change PHPDoc type of the argument.
|
@l0gicgate can you please merge this PR as soon as possible? |
l0gicgate
approved these changes
Aug 18, 2020
hhovakimyan
deleted the
change-ServerRequest-getParam-method-default-arg-phpdoc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHPDoc type of ServerRequest class getParam method's $default argument
is changed from "string" to "mixed", as dependent on request parameter its
default value can be expected to have another type(e.g. boolean). And if
there is a PHPStan or other analyser running in project an error is reported on
cases, where $default argument type is not string. So as there is no obstacle for
doing this change, it is correct to change PHPDoc type of the argument.