Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create decorated response interface #194

Merged
merged 3 commits into from
May 17, 2022
Merged

Create decorated response interface #194

merged 3 commits into from
May 17, 2022

Conversation

mporam
Copy link

@mporam mporam commented May 17, 2022

Created an interface for the decorated response object so that you can type hint slim controller actions to the interface, rather than the class, creating consistency within the action type-hint and to follow dependency inversion

@mporam mporam mentioned this pull request May 17, 2022
Merged
@l0gicgate l0gicgate added this to the 1.3.0 milestone May 17, 2022
@coveralls
Copy link

coveralls commented May 17, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 252284f on mporam:decorated-response-interface into 5b7ef26 on slimphp:master.

akrabat
akrabat approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@akrabat akrabat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
This is a good idea. Thanks.

@akrabat akrabat merged commit 0293962 into slimphp:master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrabat akrabat akrabat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mporam @coveralls @akrabat @l0gicgate