Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psr7 integration tests #32

Merged
merged 2 commits into from
Sep 22, 2017
Merged

Psr7 integration tests #32

merged 2 commits into from
Sep 22, 2017

Conversation

danopz
Copy link
Member

@danopz danopz commented Jul 6, 2017

Added php-http/psr7-integration-tests for testing our implementation. Fixed the only failing part right now - Host in Uri must be lowercase as of

The value returned MUST be normalized to lowercase, per RFC 3986

closes #31

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.212% when pulling 336f1f1 on danopz:psr7-integration into 960af6e on slimphp:master.

@akrabat
Copy link
Member

akrabat commented Sep 21, 2017

When I run the tests locally, I get:

)$ vendor/bin/phpunit
PHPUnit 6.3.0 by Sebastian Bergmann and contributors.

...............................................................  63 / 374 ( 16%)
..........................................E...................R 126 / 374 ( 33%)
RR............................................................. 189 / 374 ( 50%)
............................................................... 252 / 374 ( 67%)
............................................................... 315 / 374 ( 84%)
...........................................................     374 / 374 (100%)

Time: 808 ms, Memory: 8.00MB

There was 1 error:

1) Slim\Tests\Http\Integration\StreamTest::testClose
fclose(): supplied resource is not a valid stream resource

/Users/rob/Projects/slim-framework/Slim-Http/vendor/php-http/psr7-integration-tests/src/StreamIntegrationTest.php:64

--

There were 3 risky tests:

1) Slim\Tests\Http\Integration\UriTest::testPath
This test did not perform any assertions

2) Slim\Tests\Http\Integration\UriTest::testQuery
This test did not perform any assertions

3) Slim\Tests\Http\Integration\UriTest::testFragment
This test did not perform any assertions

ERRORS!
Tests: 374, Assertions: 583, Errors: 1, Risky: 3.

@danopz
Copy link
Member Author

danopz commented Sep 21, 2017

Looks like you have a setting which ignores the "suppress warnings @", nice btw.

This is an issue inside the psr7-integration-tests, I've created a PR to solve this one: php-http/psr7-integration-tests#17.
The risky test stuff is because of empty tests, see php-http/psr7-integration-tests#18.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.212% when pulling ab9f1f7 on danopz:psr7-integration into 344d8de on slimphp:master.

@akrabat
Copy link
Member

akrabat commented Sep 22, 2017

Aha!

@akrabat akrabat added this to the 0.4 milestone Sep 22, 2017
@akrabat akrabat merged commit ab9f1f7 into slimphp:master Sep 22, 2017
akrabat added a commit that referenced this pull request Sep 22, 2017
@danopz danopz deleted the psr7-integration branch February 4, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass PSR-7 integration tests
3 participants