-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSR-7 Decorators Migration #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use phpstan.neon.dist to ignore the tests that are expected to fail static analysis checks. Fix other PHPStan errors.
l0gicgate
commented
Oct 22, 2018
This allows encoding of false.
Closed
Belt and braces tests as our tests should cover everything here anyway.
Test against psr7-integration-tests
danopz
reviewed
Oct 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did a quick review.
For UriDecorator it is the same as for the others.
…ithX and isX methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PSR-7 Decorators
This PR is to migrate the Slim-Http repo to a decoration library for PSR-7 objects instead of a PSR-7 Implementation as discussed in #66. The will be a PR on the Slim 4 branch to reflect these changes once this branch gets merged.
This will enable us to keep all of the existing functionality from the current Slim PSR-7 implementation that was Slim-Http but giving the end user flexibility as to what PSR-7 implementation they choose.
All the tests were written and tested with the following two PSR-7 Implementations:
The Decoration Repo Provides 3 Factories which instantiate the Decorators. They respectively return PSR-7 Compatible Interfaces
Example For Instantiating a Decorated Nyholm/Psr7 Response
Example For Instantiating a Decorated Zend Diactoros Response