New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints to `\Slim\Http\Uri` #87

Merged

l0gicgate merged 2 commits into slimphp:master from adriansuter:patch-uri

May 20, 2019

Contributor

adriansuter commented May 19, 2019

This PR adds type hints to \Slim\Http\Uri.


          Add type hints

aaabf0a

coveralls commented May 19, 2019 •

edited

Loading

Coverage remained the same at 99.275% when pulling b2781e4 on adriansuter:patch-uri into 473a811 on slimphp:master.

l0gicgate reviewed

View reviewed changes

src/Uri.php Outdated Show resolved Hide resolved

l0gicgate reviewed

View reviewed changes

src/Uri.php Outdated Show resolved Hide resolved

l0gicgate reviewed

View reviewed changes

src/Uri.php Outdated Show resolved Hide resolved

l0gicgate reviewed

View reviewed changes

src/Uri.php Outdated Show resolved Hide resolved

l0gicgate reviewed

View reviewed changes

src/Uri.php Outdated Show resolved Hide resolved

l0gicgate reviewed

View reviewed changes

src/Uri.php Outdated Show resolved Hide resolved

l0gicgate reviewed

View reviewed changes

src/Uri.php Outdated Show resolved Hide resolved


          Remove self typehints

b2781e4

l0gicgate added this to the 0.8 milestone

l0gicgate approved these changes

View reviewed changes

l0gicgate merged commit 36c06df into slimphp:master

adriansuter deleted the patch-uri branch

May 20, 2019 19:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet