New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove self return typehints from Response object #89

Merged

l0gicgate merged 1 commit into slimphp:master from l0gicgate:RemoveSelfReturnTypes

May 20, 2019

Member

l0gicgate commented May 20, 2019

Reverts some changes made in #84

I missed it on the review but we can't return self because if those objects get extended it will throw an error.


          remove self return typehints from Response object

a154d12

l0gicgate added this to the 0.8 milestone

coveralls commented May 20, 2019

Coverage remained the same at 99.275% when pulling a154d12 on l0gicgate:RemoveSelfReturnTypes into 5113d8e on slimphp:master.

l0gicgate merged commit 81d8c0b into slimphp:master

l0gicgate deleted the RemoveSelfReturnTypes branch

May 24, 2019 00:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet