Add method returning client provided file path

[hhovakimyan]

UploadedFile class has a property containing temporary path of the
uploaded file, which is inaccessible outside of the class. But there is
a need of accessing this property outside of the class, when for
example you must upload the uploaded file directly to the cloud(e.g.
Amazon S3 bucket) without saving it to your local file system. So a
getter method is created returning the value of this property.

[coveralls]

Coverage remained the same at 100.0% when pulling 346854b on hhovakimyan:feature/add-method-returning-file-path-in-UploadedFile-class into 5b19133 on slimphp:master.

[hhovakimyan]

@l0gicgate @akrabat can you please merge this PR as soon as possible?

[l0gicgate]

@hhovakimyan this is not part of the PSR-7 spec, that's why it has not been implemented. Unfortunately I don't think this is necessary, it seems like this is only for the edge case in your application.

@akrabat what are your thoughts on this?

[hhovakimyan]

@l0gicgate first I don't think the case in my application is an edge case. I think many people would like to send the uploaded file directly to cloud(AWS S3 bucket, Google Drive, Dropbox, etc) without copying it to local file system and then deleting the local copy after upload succeeds. Second, if yo want to strictly follow the PSR-7 spec, there is also the option of changing the access modifier of $file property from protected to public. In Slim 3 the $file property of UploadedFile class was a public property and I used it for getting the value of uploaded file's tmp path. That's why I have a backward compatibility issue after migrating from Slim 3 to Slim 4.

[l0gicgate]

I wasn’t aware this was a regression from Slim 3.

Just for the record saying things like “Can we get this merged as fast as possible” makes me not want to merge PRs.

Instead I would advocate using suggestive language like “Would it be possible to get this merged in a timely manner?”

Thank you for your contribution

[hhovakimyan]

@l0gicgate thanks a lot for merging this pull request. Sorry for the way I have asked about merging this PR. Next time I will use suggestive language in such cases. Also can you tell me please when the 1.2 milestone is planned to be released?

[l0gicgate]

@hhovakimyan just released for you:
https://github.com/slimphp/Slim-Psr7/releases/tag/1.2.0

[piotr-cz]

Thanks @hhovakimyan.
By the way I think this should be part of a PSR-7 spec, for the reasons you outlined.