Merge branch 'issue-2500' into 4.x

Closes #2507

CHANGELOG.md

@@ -5,6 +5,7 @@
 
 ### Added
 
+- [#2507](https://github.com/slimphp/Slim/pull/2507) Method names are now case-sensitive in Router::map(), and so, by extension, in App::map() 
 - [#2529](https://github.com/slimphp/Slim/pull/2529) Slim no longer ships with a PSR-7 implementation. You need to provide a PSR-7 ServerRequest and a PSR-17 ResponseFactory to run Slim.
 - [#2497](https://github.com/slimphp/Slim/pull/2497) PSR-15 RequestHandlers can now be used as route callables
 - [#2496](https://github.com/slimphp/Slim/pull/2496) A Slim App can now be used as PSR-15 Request Handler

Slim/Router.php

@@ -187,9 +187,6 @@ public function map(array $methods, string $pattern, $handler): RouteInterface
             $pattern = $this->processGroups() . $pattern;
         }
 
-        // According to RFC methods are defined in uppercase (See RFC 7231)
-        $methods = array_map("strtoupper", $methods);
-
         /** @var Route $route */
         $route = $this->createRoute($methods, $pattern, $handler);
         $this->routes[$route->getIdentifier()] = $route;

tests/AppTest.php

@@ -241,6 +241,19 @@ public function testMapRoute()
         $this->assertAttributeContains('POST', 'methods', $route);
     }
 
+    public function testMapRouteWithLowercaseMethod()
+    {
+        $path = '/foo';
+        $callable = function ($req, $res) {
+            // Do something
+        };
+        $app = new App($this->getResponseFactory());
+        $route = $app->map(['get'], $path, $callable);
+
+        $this->assertInstanceOf('\Slim\Route', $route);
+        $this->assertAttributeContains('get', 'methods', $route);
+    }
+
     public function testRedirectRoute()
     {
         $source = '/foo';
@@ -1451,7 +1464,7 @@ public function testContainerSetToRoute()
 
         /** @var Router $router */
         $router = $app->getRouter();
-        $router->map(['get'], '/foo', 'foo:bar');
+        $router->map(['GET'], '/foo', 'foo:bar');
 
         // Invoke app
         $resOut = $app($request, $response);