Merge pull request #3139 from adoy/fix-1739

Fixed #1730 (reintroduced in 4.x)
slimphp · Jan 13, 2022 · 6aa522d · 6aa522d
2 parents 2b74627 + 85cf515
commit 6aa522d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/Slim/ResponseEmitter.php b/Slim/ResponseEmitter.php
@@ -48,8 +48,12 @@ public function emit(ResponseInterface $response): void
     {
         $isEmpty = $this->isResponseEmpty($response);
         if (headers_sent() === false) {
-            $this->emitStatusLine($response);
             $this->emitHeaders($response);
+
+            // Set the status _after_ the headers, because of PHP's "helpful" behavior with location headers.
+            // See https://github.com/slimphp/Slim/issues/1730
+
+            $this->emitStatusLine($response);
         }
 
         if (!$isEmpty) {

diff --git a/tests/ResponseEmitterTest.php b/tests/ResponseEmitterTest.php
@@ -144,9 +144,9 @@ public function testResponseReplacesPreviouslySetHeaders()
         $responseEmitter->emit($response);
 
         $expectedStack = [
-            ['header' => 'HTTP/1.1 200 OK', 'replace' => true, 'status_code' => 200],
             ['header' => 'X-Foo: baz1', 'replace' => true, 'status_code' => null],
             ['header' => 'X-Foo: baz2', 'replace' => false, 'status_code' => null],
+            ['header' => 'HTTP/1.1 200 OK', 'replace' => true, 'status_code' => 200],
         ];
 
         $this->assertSame($expectedStack, HeaderStack::stack());
@@ -162,9 +162,9 @@ public function testResponseDoesNotReplacePreviouslySetSetCookieHeaders()
         $responseEmitter->emit($response);
 
         $expectedStack = [
-            ['header' => 'HTTP/1.1 200 OK', 'replace' => true, 'status_code' => 200],
             ['header' => 'set-cOOkie: foo=bar', 'replace' => false, 'status_code' => null],
             ['header' => 'set-cOOkie: bar=baz', 'replace' => false, 'status_code' => null],
+            ['header' => 'HTTP/1.1 200 OK', 'replace' => true, 'status_code' => 200],
         ];
 
         $this->assertSame($expectedStack, HeaderStack::stack());