Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the slim4 example please. #2552

Closed
Danack opened this issue Dec 10, 2018 · 2 comments
Closed

Update the slim4 example please. #2552

Danack opened this issue Dec 10, 2018 · 2 comments
Labels

Comments

@Danack
Copy link

Danack commented Dec 10, 2018

Currently the example in the Slim4 branch doesn't work due to

$app = new Slim\App();

requires changing to something like:

$psrFactory = new Psr17Factory();
$app = new Slim\App(
    $psrFactory
);

The run line also needs changing, as:

$app->run();

requires a request to be passed in. However I can't seem to see an obviously correct way of doing that. Any suggestion please.

@akrabat
Copy link
Member

akrabat commented Dec 10, 2018

#2529 currently has the best explanations of how to run the Slim 4.x branch.

@akrabat akrabat added the Slim 4 label Dec 10, 2018
akrabat added a commit that referenced this issue Dec 10, 2018
@akrabat
Copy link
Member

akrabat commented Dec 10, 2018

@Danack Example now works. Note that you don't have to use that PSR-7 implementation though.

@akrabat akrabat closed this as completed Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants