Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP method override middleware #2329

Merged
merged 4 commits into from
Dec 23, 2017
Merged

Add HTTP method override middleware #2329

merged 4 commits into from
Dec 23, 2017

Conversation

danopz
Copy link
Member

@danopz danopz commented Nov 4, 2017 •
edited
Loading

HTTP method overriding is already removed from Slim as it was present in Request::getMethod().
So I just added a middleware to resolve #2040.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 94.963% when pulling 8f3747f on danopz:4.x into 6e1d776 on slimphp:4.x.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 94.963% when pulling df8aa7d on danopz:4.x into 6e1d776 on slimphp:4.x.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 94.963% when pulling bebbc97 on danopz:4.x into 6e1d776 on slimphp:4.x.

@akrabat akrabat added the Slim 4 label Nov 26, 2017
akrabat
akrabat requested changes Nov 26, 2017
View reviewed changes
Copy link
Member

@akrabat akrabat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no point in calling withMethod() if no method override is found. Please refactor appropriately.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 94.948% when pulling e5ee18f on danopz:4.x into e52d3ce on slimphp:4.x.

@danopz
Copy link
Member Author

danopz commented Nov 26, 2017

Done

@akrabat akrabat merged commit e5ee18f into slimphp:4.x Dec 23, 2017
akrabat added a commit that referenced this pull request Dec 23, 2017
@akrabat
Merge branch 'danopz-4.x' into 4.x
1306570 
Closes #2329
@akrabat
Copy link
Member

akrabat commented Dec 23, 2017

Thanks.

@akrabat akrabat added this to the 4.0 milestone Aug 24, 2018
@l0gicgate l0gicgate mentioned this pull request Apr 25, 2019
Merged
@l0gicgate l0gicgate mentioned this pull request Aug 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrabat akrabat akrabat approved these changes

Assignees
No one assigned
Labels
Slim 4
Projects
None yet
Milestone
4.0.0-alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@danopz @coveralls @akrabat