4.x Refactor RouteGroup & Route #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0gicgate
changed the title
7 tasks
akrabat
reviewed
Mar 19, 2019
|
Looks reasonable to me. |
l0gicgate
changed the title
akrabat
approved these changes
Apr 2, 2019
|
Do we need a CHANGELOG entry? |
|
@akrabat yeah I think so. The public interface has changed for both |
akrabat
added a commit
that referenced
this pull request
Apr 2, 2019
This was referenced Apr 21, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pull 1 out of 7 to complete the goals set in #2604
RouteGroupso it doesn't extendRoutableappendMiddlewareToDispatcher()method to avoid encapsulation leakageRoute::finalize()and fold it intoRoute::run()Routableas it is now obsolete.This PR effectively closes #2598, #2599 and #2600.