Emit non seekable streams #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowhand
reviewed
Aug 15, 2019
| if ($seekable) { | ||
| $stream->rewind(); | ||
| } | ||
| return $seekable ? $stream->read(1) === '' : $stream->eof(); |
There was a problem hiding this comment.
Could this be made easier with ... ?
return $stream->getSize() > 0;There was a problem hiding this comment.
Your logic condition need to invert. return !$stream->getSize() > 0. Please, run unit tests with your code. You will see some errors (AppTest errors can be ignored). The most interesting is the error Slim\Tests\ResponseEmitterTest::testRespondIndeterminateLength. It shows that reading from a stream of at least one byte is the most reliable way. I myself don’t like such excessive complexity.
There was a problem hiding this comment.
I found yet another example. Resource $resource = popen('echo 12', 'r') will be defined as empty, but in reality has content.
l0gicgate
approved these changes
Aug 15, 2019
adriansuter
approved these changes
Aug 15, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time when we emit any response we read all data from a stream twice.
There may be problems with slow streams or responses with too big body. In addition, with a such
ResponseEmitterwork, it is impossible to send a response with non seekable body.