Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2841

Merged
merged 2 commits into from
Sep 21, 2019
Merged

Update README.md #2841

merged 2 commits into from
Sep 21, 2019

Conversation

mokevnin
Copy link
Contributor

It looks like the index.php is inside the public directory, but there is no information about it.

It looks like the _index.php_ is inside the _public_ directory, but there is no information about it.
@coveralls
Copy link

coveralls commented Sep 19, 2019

Coverage Status

Coverage remained the same at ?% when pulling 9a1c775 on mokevnin:patch-1 into 4d490ab on slimphp:4.x.

@froschdesign
Copy link

It looks like the index.php is inside the public directory, but there is no information about it.

Good catch, but the vendor directory does not belong in the public area. My suggestion: add a filename before the code example or as commend in the code example.

make "Hello, World!" example more clear
@mokevnin
Copy link
Contributor Author

One more time)

@l0gicgate l0gicgate added this to the 4.3.0 milestone Sep 20, 2019
@l0gicgate l0gicgate merged commit 62b7295 into slimphp:4.x Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants